[
https://issues.apache.org/jira/browse/FLINK-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706429#comment-14706429
]
ASF GitHub Bot commented on FLINK-2077:
---------------------------------------
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1035#issuecomment-133340112
Hi @gallenvara, great to see that more and more new people join the Flink
community :-)
IMHO, whether a method is used from within the same class or not is not a
good indicator for moving a method out of it. You'll find many classes in Flink
which define methods which are not used by itself. It's part of the idea of OOP
that the methods you define on a class constitute the interface to it. Thus, it
defines what you can do with it. In that sense, `makeQualified` should stay
part of the `Path` class, because it allows you to create a qualified path
object from another path object.
Moreover, scattering functionality around in some static util classes won't
make it easier for others to actually find it. How should people know that
there is a class `FileSystemUtil` which allows you to convert paths into
qualified paths? It's more natural to look at the methods defined in the `Path`
class. Having much code in one class is not per se bad if you structure it
clearly and if your methods don't become behemoths it's fine. I also don't
think that @fhueske had this in mind when he created the JIRA issue.
Maybe I'm totally wrong here, but I think we should close this PR.
> Rework Path class and add extend support for Windows paths
> ----------------------------------------------------------
>
> Key: FLINK-2077
> URL: https://issues.apache.org/jira/browse/FLINK-2077
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.9
> Reporter: Fabian Hueske
> Assignee: GaoLun
> Priority: Minor
> Labels: starter
>
> The class {{org.apache.flink.core.fs.Path}} handles paths for Flink's
> {{FileInputFormat}} and {{FileOutputFormat}}. Over time, this class has
> become quite hard to read and modify.
> It would benefit from some cleaning and refactoring. Along with the
> refactoring, support for Windows paths like {{//host/dir1/dir2}} could be
> added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
