[ 
https://issues.apache.org/jira/browse/FLINK-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706343#comment-14706343
 ] 

ASF GitHub Bot commented on FLINK-2077:
---------------------------------------

Github user gallenvara commented on the pull request:

    https://github.com/apache/flink/pull/1035#issuecomment-133315613
  
    @tillrohrmann  I'm new to Flink. Thanks for your words and if i have any 
mistake please point it out.
    My idea on this issue is : 
    the ```Path``` class has become quite hard to read and modify. In 
```Path``` class, the ```makeQualified``` method hasn't been called once.In 
order to reduce the amount of ```Path``` code and make the class much more 
thinner ,i have moved it to the util named ```FileSystemUtil``` as a tool. 
Also, i think the ```Path``` class handles the input and output's path.The 
```makeQualified``` method handles the FileSystem . I think they are parellel.
    So i create the ```FileSystemUtil``` as a tool instead of being a method in 
```Path``` class.


> Rework Path class and add extend support for Windows paths
> ----------------------------------------------------------
>
>                 Key: FLINK-2077
>                 URL: https://issues.apache.org/jira/browse/FLINK-2077
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.9
>            Reporter: Fabian Hueske
>            Assignee: GaoLun
>            Priority: Minor
>              Labels: starter
>
> The class {{org.apache.flink.core.fs.Path}} handles paths for Flink's 
> {{FileInputFormat}} and {{FileOutputFormat}}. Over time, this class has 
> become quite hard to read and modify. 
> It would benefit from some cleaning and refactoring. Along with the 
> refactoring, support for Windows paths like {{//host/dir1/dir2}} could be 
> added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to