[
https://issues.apache.org/jira/browse/FLINK-10827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683667#comment-16683667
]
ASF GitHub Bot commented on FLINK-10827:
----------------------------------------
StefanRRichter commented on issue #7061: [FLINK-10827][tests] Add test for
duplicate() to SerializerTestBase
URL: https://github.com/apache/flink/pull/7061#issuecomment-437854190
@tillrohrmann I addressed the comments, please have another look. I think
the duplicate code is correct as it was because `registeredSerializers` etc is
handled in the constructor that was use to duplicate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add test for duplicate() to SerializerTestBase
> ----------------------------------------------
>
> Key: FLINK-10827
> URL: https://issues.apache.org/jira/browse/FLINK-10827
> Project: Flink
> Issue Type: Test
> Components: Tests
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> In the past, we had many bugs from type serializers that have not properly
> implemented the {{duplicate()}} method in a proper way. A very common error
> is to forget about creating a deep copy of some fields that can lead to
> concurrency problems in the backend.
> We should add a test case for that tests duplicated serializer from different
> threads to expose concurrency problems.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
