[
https://issues.apache.org/jira/browse/FLINK-10827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683428#comment-16683428
]
ASF GitHub Bot commented on FLINK-10827:
----------------------------------------
StefanRRichter commented on a change in pull request #7061:
[FLINK-10827][tests] Add test for duplicate() to SerializerTestBase
URL: https://github.com/apache/flink/pull/7061#discussion_r232572989
##########
File path:
flink-core/src/test/java/org/apache/flink/api/common/typeutils/SerializerTestBase.java
##########
@@ -436,6 +441,36 @@ public void testNullability() {
}
}
+ @Test
+ public void testDuplicate() throws Exception {
+ final int numThreads = 10;
+ final TypeSerializer<T> serializer = getSerializer();
+ final OneShotLatch startLatch = new OneShotLatch();
+ final List<SerializerRunner<T>> concurrentRunners = new
ArrayList<>(numThreads);
+ Assert.assertEquals(serializer, serializer.duplicate());
+
+ T[] testData = getData();
+ final int testDataIterations = Math.max(1, 250 /
testData.length);
+
+ for (int i = 0; i < numThreads; ++i) {
+ SerializerRunner<T> runner = new SerializerRunner<>(
+ startLatch,
Review comment:
What would be the benefit? This feels like it does exactly what we want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add test for duplicate() to SerializerTestBase
> ----------------------------------------------
>
> Key: FLINK-10827
> URL: https://issues.apache.org/jira/browse/FLINK-10827
> Project: Flink
> Issue Type: Test
> Components: Tests
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> In the past, we had many bugs from type serializers that have not properly
> implemented the {{duplicate()}} method in a proper way. A very common error
> is to forget about creating a deep copy of some fields that can lead to
> concurrency problems in the backend.
> We should add a test case for that tests duplicated serializer from different
> threads to expose concurrency problems.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
