yanghua commented on a change in pull request #6924: [FLINK-10600] Provide
End-to-end test cases for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#discussion_r229773839
##########
File path: flink-examples/flink-examples-streaming/pom.xml
##########
@@ -60,6 +60,18 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-kafka-0.10_${scala.binary.version}</artifactId>
<version>${project.version}</version>
+ <exclusions>
Review comment:
@pnowojski @tzulitai The result is not as expected (it failed), and even if
we use `artifactSet / exculde` to exclude other connectors, the dependency on
kafka-client is still wrong. So I'll take your advice and split the test
implementation of the modern Kafka connector into separate modules. But because
of the logical similarity, do you recommend that I introduce a base
implementation (in a new base module)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
