yanghua commented on a change in pull request #6924: [FLINK-10600] Provide 
End-to-end test cases for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#discussion_r228883766
 
 

 ##########
 File path: flink-examples/flink-examples-streaming/pom.xml
 ##########
 @@ -568,6 +585,49 @@ under the License.
                                                </configuration>
                                        </execution>
 
+                                       <execution>
+                                               <id>fat-jar-kafka-example</id>
+                                               <phase>package</phase>
+                                               <goals>
+                                                       <goal>shade</goal>
+                                               </goals>
+                                               <configuration>
+                                                       
<shadeTestJar>false</shadeTestJar>
+                                                       
<shadedArtifactAttached>false</shadedArtifactAttached>
+                                                       
<createDependencyReducedPom>false</createDependencyReducedPom>
+                                                       <transformers>
+                                                               <transformer 
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+                                                                       
<mainClass>org.apache.flink.streaming.examples.kafka.KafkaExample</mainClass>
+                                                               </transformer>
+                                                       </transformers>
+                                                       
<finalName>KafkaExample</finalName>
+                                                       <!-- 
<outputFile>Kafka.jar</outputFile> -->
 
 Review comment:
   It comes from the execution of `fat-jar-kafka-010-example`, I just copied 
it. Will remove.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to