[
https://issues.apache.org/jira/browse/FLINK-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650346#comment-16650346
]
ASF GitHub Bot commented on FLINK-10511:
----------------------------------------
Clarkkkkk commented on issue #6845: [FLINK-10511][Cluster Management] Reuse the
port selection and RPC se…
URL: https://github.com/apache/flink/pull/6845#issuecomment-429893419
cc @tillrohrmann
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Code duplication of creating RPC service in ClusterEntrypoint and
> AkkaRpcServiceUtils
> -------------------------------------------------------------------------------------
>
> Key: FLINK-10511
> URL: https://issues.apache.org/jira/browse/FLINK-10511
> Project: Flink
> Issue Type: Improvement
> Components: Cluster Management
> Reporter: Shimin Yang
> Assignee: Shimin Yang
> Priority: Minor
> Labels: pull-request-available
>
> The TaskManagerRunner is using AkkaRpcServiceUtils to create RPC service, but
> the ClusterEntrypoint use a protected method to do the same job. I think it's
> better to use the same method in AkkaRpcServiceUtils for reuse of code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
