[ 
https://issues.apache.org/jira/browse/FLINK-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647692#comment-16647692
 ] 

Shimin Yang commented on FLINK-10511:
-------------------------------------

[~till.rohrmann], good point. We can add an override function createRpcService 
takes port range as parameter and use the BootstrapTools to start an actor 
system in AkkaRpcServiceUtils.

> Code duplication of creating RPC service in ClusterEntrypoint and 
> AkkaRpcServiceUtils
> -------------------------------------------------------------------------------------
>
>                 Key: FLINK-10511
>                 URL: https://issues.apache.org/jira/browse/FLINK-10511
>             Project: Flink
>          Issue Type: Bug
>          Components: Cluster Management
>            Reporter: Shimin Yang
>            Assignee: Shimin Yang
>            Priority: Minor
>
> The TaskManagerRunner is using AkkaRpcServiceUtils to create RPC service, but 
> the ClusterEntrypoint use a protected method to do the same job. I think it's 
> better to use the same method in AkkaRpcServiceUtils for reuse of code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to