[
https://issues.apache.org/jira/browse/FLINK-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648092#comment-16648092
]
ASF GitHub Bot commented on FLINK-10398:
----------------------------------------
yanghua commented on a change in pull request #6736: [FLINK-10398][table] Add
Tanh math function supported in Table API and SQL
URL: https://github.com/apache/flink/pull/6736#discussion_r224845010
##########
File path: docs/dev/table/functions.md
##########
@@ -1219,6 +1219,18 @@ TAN(numeric)
</td>
</tr>
+ <tr>
+ <td>
+ {% highlight text %}
+TANH(numeric)
+{% endhighlight %}
+ </td>
+ <td>
+ <p>Returns the hyperbolic tangent of <i>NUMERIC</i>.</p>
+ <p>Return value type is <i>DOUBLE</i>.</p>
Review comment:
In fact, I just followed the [same
pattern](https://github.com/apache/flink/pull/6700/files#diff-51c7d3bf736c60e8b942791a3715cbffR1284)
as the PR of cosh, which looks good to Piotr, and according to Piotr's advice:
[the type is best written
uniformly](https://github.com/apache/flink/pull/6700#discussion_r220892667),
and you haven't objected to this point before. But here you suggest I change it
to lowercase. Your guidelines seem vague.
However, there is also my problem. I should have made these functions in the
same PR to make the change more effective. There are a few points that I
probably didn't pay much attention to, but I think many of the points you
mentioned earlier are about documentation. Document description, however, has
no definite criteria, and may be what you think is standard, but another person
disagrees. So it caused a lot of reciprocating.
Plus, if you're willing to review, I think it's more contributor-friendly
for you to give a definite review conclusion once (except for new problems
arising from secondary changes). I feel that each time you give a partial
review suggestion (some of which are not related to my last change), it also
creates more reciprocity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Tanh math function supported in Table API and SQL
> -----------------------------------------------------
>
> Key: FLINK-10398
> URL: https://issues.apache.org/jira/browse/FLINK-10398
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Minor
> Labels: pull-request-available
>
> refer to : https://www.techonthenet.com/oracle/functions/tanh.php
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
