[ https://issues.apache.org/jira/browse/FLINK-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648070#comment-16648070 ]
ASF GitHub Bot commented on FLINK-10398: ---------------------------------------- xccui commented on a change in pull request #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6736#discussion_r224835500 ########## File path: docs/dev/table/functions.md ########## @@ -1219,6 +1219,18 @@ TAN(numeric) </td> </tr> + <tr> + <td> + {% highlight text %} +TANH(numeric) +{% endhighlight %} + </td> + <td> + <p>Returns the hyperbolic tangent of <i>NUMERIC</i>.</p> + <p>Return value type is <i>DOUBLE</i>.</p> Review comment: Change the `NUMERIC` to lowercase here. The return type is ... Please ALWAYS be careful with these minor issues cause they have been pointed out many times. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Tanh math function supported in Table API and SQL > ----------------------------------------------------- > > Key: FLINK-10398 > URL: https://issues.apache.org/jira/browse/FLINK-10398 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL > Reporter: vinoyang > Assignee: vinoyang > Priority: Minor > Labels: pull-request-available > > refer to : https://www.techonthenet.com/oracle/functions/tanh.php -- This message was sent by Atlassian JIRA (v7.6.3#76005)