[
https://issues.apache.org/jira/browse/FLINK-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630294#comment-16630294
]
ASF GitHub Bot commented on FLINK-10340:
----------------------------------------
pnowojski commented on a change in pull request #6700: [FLINK-10340][table] Add
Cosh math function supported in Table API and SQL
URL: https://github.com/apache/flink/pull/6700#discussion_r220900367
##########
File path: docs/dev/table/functions.md
##########
@@ -1274,6 +1274,17 @@ ATAN2(numeric1, numeric2)
</td>
</tr>
+ <tr>
+ <td>
+ {% highlight text %}
+COSH(numeric)
+{% endhighlight %}
+ </td>
+ <td>
+ <p>Returns the hyperbolic cosine of <i>numeric</i>. Return value type
is DOUBLE.</p>
Review comment:
Can you make consistent with for example with this:
https://ci.apache.org/projects/flink/flink-docs-master/dev/table/tableApi.html#data-types
So capital letters mono space `DOUBLE` and `NUMERIC`? (using ` character in
md.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Cosh math function supported in Table API and SQL
> -----------------------------------------------------
>
> Key: FLINK-10340
> URL: https://issues.apache.org/jira/browse/FLINK-10340
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.6.0
> Reporter: Sergey Tsvetkov
> Assignee: vinoyang
> Priority: Minor
> Labels: pull-request-available
>
> Implement udf of cosh, just like in oracle
> [https://docs.oracle.com/cd/B28359_01/server.111/b28286/functions031.htm#SQLRF00623]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
