[ https://issues.apache.org/jira/browse/FLINK-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630272#comment-16630272 ]
ASF GitHub Bot commented on FLINK-10340: ---------------------------------------- pnowojski commented on a change in pull request #6700: [FLINK-10340][table] Add Cosh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6700#discussion_r220892667 ########## File path: docs/dev/table/functions.md ########## @@ -1274,6 +1274,17 @@ ATAN2(numeric1, numeric2) </td> </tr> + <tr> + <td> + {% highlight text %} +COSH(numeric) +{% endhighlight %} + </td> + <td> + <p>Returns the hyperbolic cosine of <i>numeric</i>. Return value type is DOUBLE.</p> Review comment: Could you make type references consistent `<i>TYPE_NAME</i>? You are using any combination of small case, capital case, with or without italic :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Cosh math function supported in Table API and SQL > ----------------------------------------------------- > > Key: FLINK-10340 > URL: https://issues.apache.org/jira/browse/FLINK-10340 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL > Affects Versions: 1.6.0 > Reporter: Sergey Tsvetkov > Assignee: vinoyang > Priority: Minor > Labels: pull-request-available > > Implement udf of cosh, just like in oracle > [https://docs.oracle.com/cd/B28359_01/server.111/b28286/functions031.htm#SQLRF00623] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)