[ https://issues.apache.org/jira/browse/FLINK-10354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617551#comment-16617551 ]
ASF GitHub Bot commented on FLINK-10354: ---------------------------------------- dawidwys commented on issue #6704: [FLINK-10354] Revert "[FLINK-6328] [chkPts] Don't add savepoints to CompletedCheckpointStore" URL: https://github.com/apache/flink/pull/6704#issuecomment-422025668 Unfortunately we will fail the recovery in this situation , but as discussed with @aljoscha this is a better situation than breaking consistency guarantees. This would be a faulty situation introduced by the user, but one the user can recover from manually. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Savepoints should be counted as retained checkpoints > ---------------------------------------------------- > > Key: FLINK-10354 > URL: https://issues.apache.org/jira/browse/FLINK-10354 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing > Affects Versions: 1.6.0 > Reporter: Dawid Wysakowicz > Assignee: Dawid Wysakowicz > Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > > This task is about reverting [FLINK-6328]. > The problem is that you can get incorrect results with exactly-once sinks if > there is a failure after taking a savepoint but before taking the next > checkpoint because the savepoint will also have manifested side effects to > the sink. -- This message was sent by Atlassian JIRA (v7.6.3#76005)