[
https://issues.apache.org/jira/browse/FLINK-10354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620299#comment-16620299
]
ASF GitHub Bot commented on FLINK-10354:
----------------------------------------
tzulitai commented on issue #6704: [FLINK-10354] Revert "[FLINK-6328] [chkPts]
Don't add savepoints to CompletedCheckpointStore"
URL: https://github.com/apache/flink/pull/6704#issuecomment-422712305
The reverted changes looks good by itself, but I personally don't feel too
comfortable giving a +1 here. Perhaps Till should give the final approval here.
If we do plan to revert this, we should at least have a big warning in the
savepoints document page about how things could break.
Also as a side note, in the original JIRA discussion, it was mentioned that
if we had FLINK-4815 merged, then it can be considered that we readd savepoints
to the CompletedCheckpointsStore. How would that relate to the long-term
solution that @dawidwys mentioned?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Savepoints should be counted as retained checkpoints
> ----------------------------------------------------
>
> Key: FLINK-10354
> URL: https://issues.apache.org/jira/browse/FLINK-10354
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Affects Versions: 1.6.0
> Reporter: Dawid Wysakowicz
> Assignee: Dawid Wysakowicz
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> This task is about reverting [FLINK-6328].
> The problem is that you can get incorrect results with exactly-once sinks if
> there is a failure after taking a savepoint but before taking the next
> checkpoint because the savepoint will also have manifested side effects to
> the sink.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
