[
https://issues.apache.org/jira/browse/FLINK-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602881#comment-16602881
]
ASF GitHub Bot commented on FLINK-10242:
----------------------------------------
zentol opened a new pull request #6656: [FLINK-10242][metrics] Disable latency
metrics by default
URL: https://github.com/apache/flink/pull/6656
## What is the purpose of the change
This PR disables latency tracking by default, and adds a config option for
configuring the default latency tracking interval.
The added config option allows users to restore the previous behavior
without recompiling all jobs. Job-specific configuration via the
`ExecutionConfig` take precedence over the configured value, to ensure that
existing jobs that disabled latency tracking continue to do so.
## Brief change log
* extend `MockEnvironment` to support setting the `TaskManagerRuntimeInfo`
* split `StreamSourceOperatorTest` into watermark/split parts
* add `MetricOptions#LATENCY_INTERVAL` for configuring the default latency
tracking interval
* set `ExecutionConfig#latencyTrackingInterval` to
`MetricOptions.LATENCY_INTERVAL.defaultValue()`
* add `ExecutionConfig#isLatencyTrackingConfigured` to track whether
job-specific settings were applied
* modify `StreamSource#run` to take configured value into account
* deprecate `ExecutionConfig#isLatencyTrackingEnabled` since it is no longer
used, misleading as it doesn't take the configuration into account and requires
us to duplicate the interpretation of the interval (i.e. that latency tracking
is disabled if it is <= 0)
## Verifying this change
See `StreamSourceOperatorLatencyMetricsTest`. This class is a large
extension of the existing `StreamSourceOperatorTest#testLatencyMarkEmission`
test (which passed before the refactoring).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Disable latency metrics by default
> ----------------------------------
>
> Key: FLINK-10242
> URL: https://issues.apache.org/jira/browse/FLINK-10242
> Project: Flink
> Issue Type: Sub-task
> Components: Configuration, Metrics
> Affects Versions: 1.7.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> With the plethora of recent issue around latency metrics we should disable
> them by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
