GJL commented on issue #6601: [FLINK-10193] Add @RpcTimeout to JobMasterGateway.triggerSavepoint URL: https://github.com/apache/flink/pull/6601#issuecomment-415061650 @tillrohrmann The value of the timeout from the perspective of the method implementation will always be what is passed to the RPC. This is regardless of whether the annotation is present or not because if the annotation is missing, the `AkkaInvocationHandler`, cannot know which item in the args array should be replaced with the default timeout. If the call originates from the REST API, the value will be `RpcUtils.INF_TIMEOUT`: https://github.com/apache/flink/blob/6258a4c333ce9dba914621b13eac2f7d91f5cb72/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java#L132 I can add a test to the handler test suite but this will not verify my change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
