GJL commented on issue #6601: [FLINK-10193] Add @RpcTimeout to 
JobMasterGateway.triggerSavepoint
URL: https://github.com/apache/flink/pull/6601#issuecomment-415012048
 
 
   I see the following possibilities to test this:
   
   1. Override `triggerSavepoint` to a NOP, and trigger savepoint twice with 
increasing timeouts. The second invocation should fail later.
   2. Check for presence of the annotation with reflection.
   
   I deliberately did not add tests because Option 1 is slow and depends on
   _"good"_ thread scheduling. Option 2 is fragile and not refactoring friendly.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to