Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6120#discussion_r201655890
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java 
---
    @@ -584,21 +581,6 @@ private static void registerFactory(Type t, Class<? 
extends TypeInfoFactory> fac
                                // number of parameters the SAM of implemented 
interface has; the parameter indexing applies to this range
                                final int baseParametersLen = 
sam.getParameterTypes().length;
     
    -                           // executable references "this" implicitly
    -                           if (paramLen <= 0) {
    -                                   // executable declaring class can also 
be a super class of the input type
    -                                   // we only validate if the executable 
exists in input type
    -                                   validateInputContainsExecutable(exec, 
inType);
    -                           }
    -                           else {
    -                                   final Type input = 
TypeExtractionUtils.extractTypeFromLambda(
    -                                           exec,
    -                                           lambdaInputTypeArgumentIndices,
    --- End diff --
    
    If you removed checking the input type info the parameter 
`lambdaInputTypeArgumentIndices` is no longer necessary.


---

Reply via email to