Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6132#discussion_r198493145
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerTest.java
 ---
    @@ -1202,6 +1209,111 @@ public void testSlotRequestFailure() throws 
Exception {
                }
        }
     
    +   /**
    +    * Tests notify the job manager when the task manager is failed/killed.
    +    */
    +   @Test
    +   public void testNotifyTaskManagerFailed() throws Exception {
    +
    +           final List<Tuple4<JobID, ResourceID, Set<AllocationID>, 
Exception>> notifiedTaskManagerInfos = new ArrayList<>();
    +
    +           try (final SlotManager slotManager = 
createSlotManager(ResourceManagerId.generate(), new TestingResourceActions() {
    +                   @Override
    +                   public void notifyTaskManagerTerminated(JobID jobId, 
ResourceID resourceID, Set<AllocationID> allocationIDs, Exception cause) {
    +                           notifiedTaskManagerInfos.add(new 
Tuple4<>(jobId, resourceID, allocationIDs, cause));
    +                   }
    +           })) {
    --- End diff --
    
    Indentation looks a bit off here


---

Reply via email to