Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6132#discussion_r198491333
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java
---
@@ -278,4 +279,13 @@ void heartbeatFromTaskManager(
* not available (yet).
*/
CompletableFuture<OperatorBackPressureStatsResponse>
requestOperatorBackPressureStats(JobVertexID jobVertexId);
+
+ /**
+ * Notifies that the task manager has terminated.
+ *
+ * @param resourceID identifying the task manager
+ * @param allocationIDs held by this job that belong to the task manager
+ * @param cause of the task manager termination
+ */
+ void taskManagerTerminated(ResourceID resourceID, Set<AllocationID>
allocationIDs, Exception cause);
--- End diff --
methods should usually be a verb. What about `notifyTaskManagerTermination`?
---
