Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6147#discussion_r195046491
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
    @@ -581,6 +582,8 @@ public String toString() {
        }
     
        public void uploadUserArtifacts(InetSocketAddress blobServerAddress, 
Configuration clientConfig) throws IOException {
    --- End diff --
    
    Could we move this method out of the `JobGraph`? It basically couples the 
`JobGraph` with the `BlobClient` which is not necessary. I would rather prefer 
that the submission method of the `JobGraph` makes sure that everything is 
properly uploaded and then updates the `DistributedCacheEntries`.


---

Reply via email to