Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6147#discussion_r195036853
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java 
---
    @@ -273,26 +269,8 @@ public Path call() throws IOException {
                        final File file = blobService.getFile(jobID, blobKey);
    --- End diff --
    
    Here is a slight inconsistency with respect to the file type. If the file 
under `blobKey` is a file, then it is left in the ownership of the 
`BlobService`. If it is a zipped directory, then we expand the file under 
`<tmp-dir>/tmp_<jobID>/` which is deleted 5 seconds after the last task holding 
a reference to it is released. This is not a deal breaker but we should at 
least update the java docs such that they state the difference. 


---

Reply via email to