[
https://issues.apache.org/jira/browse/FLINK-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642658#comment-14642658
]
ASF GitHub Bot commented on FLINK-2404:
---------------------------------------
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/942
[FLINK-2404]Primitive add methods to Accumulators
Adds primitive add value methods to Double, Int and Long counter.
Benchmark: Run independently of Flink on the LongCounter accumulator.
No Add | Long Add | long Add
------ | -------- | --------
1458.9 | 2785.7 | 2169.7
[Time for 1e+9 additions]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sachingoel0101/flink flink-2404
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/942.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #942
----
commit f70a261adcb50e557d75c810c2c95c224edf2cc8
Author: Sachin Goel <sachingoel0...@gmail.com>
Date: 2015-07-27T11:23:18Z
Added primitive add methods
----
> LongCounters should have an "addValue()" method for primitive longs
> -------------------------------------------------------------------
>
> Key: FLINK-2404
> URL: https://issues.apache.org/jira/browse/FLINK-2404
> Project: Flink
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.10
> Reporter: Stephan Ewen
> Fix For: 0.10
>
>
> Since the LongCounter is used heavily for internal statistics reporting, it
> must have very low overhead.
> The current "addValue()" method always boxes and unboxes the values, which is
> unnecessary overhead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
