[ 
https://issues.apache.org/jira/browse/FLINK-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642589#comment-14642589
 ] 

Sachin Goel commented on FLINK-2404:
------------------------------------

I ran a dummy filter job to test any performance improvement that might happen 
because of using the primitive add methods.
Data: (1,1e+6), Local cluster with parallelism 1.
Time:
1. No call to add: 569.6 ms
2. Add Long: 601.2 ms
3. Add long: 598.1 ms

There doesn't appear to be any significant improvement. Should I still open a 
PR?

> LongCounters should have an "addValue()" method for primitive longs
> -------------------------------------------------------------------
>
>                 Key: FLINK-2404
>                 URL: https://issues.apache.org/jira/browse/FLINK-2404
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.10
>            Reporter: Stephan Ewen
>             Fix For: 0.10
>
>
> Since the LongCounter is used heavily for internal statistics reporting, it 
> must have very low overhead.
> The current "addValue()" method always boxes and unboxes the values, which is 
> unnecessary overhead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to