[ 
https://issues.apache.org/jira/browse/FLINK-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452243#comment-16452243
 ] 

ASF GitHub Bot commented on FLINK-2435:
---------------------------------------

Github user kenmy commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5862#discussion_r184057665
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
    @@ -89,14 +94,14 @@
         * the state of this parser.
         * The start position within the byte array and the array's valid 
length is given.
         * The content of the value is delimited by a field delimiter.
    -    * 
    --- End diff --
    
    Could you delete excess changes


> Add support for custom CSV field parsers
> ----------------------------------------
>
>                 Key: FLINK-2435
>                 URL: https://issues.apache.org/jira/browse/FLINK-2435
>             Project: Flink
>          Issue Type: New Feature
>          Components: DataSet API
>    Affects Versions: 0.10.0
>            Reporter: Fabian Hueske
>            Assignee: Dmitrii Kober
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> The {{CSVInputFormats}} have only {{FieldParsers}} for Java's primitive types 
> (byte, short, int, long, float, double, boolean, String).
> It would be good to add support for CSV field parsers for custom data types 
> which can be registered in a {{CSVReader}}. 
> We could offer two interfaces for field parsers.
> 1. The regular low-level {{FieldParser}} which operates on a byte array and 
> offsets.
> 2. A {{StringFieldParser}} which operates on a String that has been extracted 
> by a {{StringParser}} before. This interface will be easier to implement but 
> less efficient.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to