[
https://issues.apache.org/jira/browse/FLINK-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441211#comment-16441211
]
Dmitrii Kober commented on FLINK-2435:
--------------------------------------
Hello [~fhueske]. Thank you for the review! I have updated the code and raised
a new pull-request for the first couple of comments:
- reverting all unnecessary changes such as changing import order or white
space changes
- merging all commits into a single commit
Could you please help with clarifying the last two?
- check if the changes to `TupleTypeInfo` are required. _This change is done
to let a user-defined class be a part of a Tuple instance (as far as a tuple is
a fixed-length 'value container'), similar to an 'unbounded' Row). Otherwise,
only Basic and BasicValue types could be used._
- check if we can add this feature without adding a dependency to
`flink-java`. _Currently, CsvReader class resides in 'flink-java' package. Do
you mean that this class should be migrated to 'flink-core'_ ?
> Add support for custom CSV field parsers
> ----------------------------------------
>
> Key: FLINK-2435
> URL: https://issues.apache.org/jira/browse/FLINK-2435
> Project: Flink
> Issue Type: New Feature
> Components: DataSet API
> Affects Versions: 0.10.0
> Reporter: Fabian Hueske
> Assignee: Dmitrii Kober
> Priority: Minor
> Fix For: 1.0.0
>
>
> The {{CSVInputFormats}} have only {{FieldParsers}} for Java's primitive types
> (byte, short, int, long, float, double, boolean, String).
> It would be good to add support for CSV field parsers for custom data types
> which can be registered in a {{CSVReader}}.
> We could offer two interfaces for field parsers.
> 1. The regular low-level {{FieldParser}} which operates on a byte array and
> offsets.
> 2. A {{StringFieldParser}} which operates on a String that has been extracted
> by a {{StringParser}} before. This interface will be easier to implement but
> less efficient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
