[
https://issues.apache.org/jira/browse/FLINK-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442280#comment-16442280
]
ASF GitHub Bot commented on FLINK-9193:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5868#discussion_r182387176
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/WriteSinkFunctionByMillis.java
---
@@ -1,53 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.streaming.api.functions.sink;
-
-import org.apache.flink.annotation.PublicEvolving;
-
-/**
- * Implementation of WriteSinkFunction. Writes tuples to file in every
millis
- * milliseconds.
- *
- * @param <IN>
- * Input tuple type
- */
-@PublicEvolving
--- End diff --
I think we should, because they are bogus and no-one should actually use
them.
There is already a follow-up issue:
https://issues.apache.org/jira/browse/FLINK-9195 😅
> Deprecate non-well-defined output methods on DataStream
> -------------------------------------------------------
>
> Key: FLINK-9193
> URL: https://issues.apache.org/jira/browse/FLINK-9193
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Major
> Fix For: 1.5.0
>
>
> Some output methods on {{DataStream}} that write text to files are not safe
> to use in a streaming program as they have no consistency guarantees. They
> are:
> - {{writeAsText()}}
> - {{writeAsCsv()}}
> - {{writeToSocket()}}
> - {{writeUsingOutputFormat()}}
> Along with those we should also deprecate the {{SinkFunctions}} that they use.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
