Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/896#discussion_r34268940
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -172,13 +173,20 @@
/** The library cache, from which the task can request its required JAR
files */
private final LibraryCacheManager libraryCache;
-
+
/** The cache for user-defined files that the invokable requires */
private final FileCache fileCache;
-
+
/** The gateway to the network stack, which handles inputs and produced
results */
private final NetworkEnvironment network;
+ /** The registry of this task which enables live reporting of
accumulators */
+ private final AccumulatorRegistry accumulatorRegistry;
+
+ public AccumulatorRegistry getAccumulatorRegistry() {
--- End diff --
The structure of the class declares fields in one section, and getters in
another. Would be good to follow that, makes the code easier to navigate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
