Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/896#discussion_r34268803
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/RuntimeEnvironment.java
 ---
    @@ -212,19 +218,19 @@ public InputGate getInputGate(int index) {
                return inputGates;
        }
     
    -   @Override
    -   public void reportAccumulators(Map<String, Accumulator<?, ?>> 
accumulators) {
    -           AccumulatorEvent evt;
    -           try {
    -                   evt = new AccumulatorEvent(getJobID(), accumulators);
    -           }
    -           catch (IOException e) {
    -                   throw new RuntimeException("Cannot serialize 
accumulators to send them to JobManager", e);
    -           }
    -
    -           ReportAccumulatorResult accResult = new 
ReportAccumulatorResult(jobId, executionId, evt);
    -           jobManagerActor.tell(accResult, ActorRef.noSender());
    -   }
    +// @Override
    --- End diff --
    
    This can be properly removed, no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to