Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5397#discussion_r165666773
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TestingTaskExecutorGateway.java
 ---
    @@ -75,6 +76,17 @@ public void 
setDisconnectJobManagerConsumer(Consumer<Tuple2<JobID, Throwable>> d
                return CompletableFuture.completedFuture(Acknowledge.get());
        }
     
    +   @Override
    +   public CompletableFuture<StackTraceSampleResponse> 
requestStackTraceSample(
    --- End diff --
    
    or maybe not


---

Reply via email to