Github user eastcirclek commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5307#discussion_r164597051
  
    --- Diff: 
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
 ---
    @@ -238,6 +254,12 @@ public static MesosTaskManagerParameters 
create(Configuration flinkConfig) {
                        cpus = Math.max(containeredParameters.numSlots(), 1.0);
                }
     
    +           double gpus = 
Math.floor(flinkConfig.getDouble(MESOS_RM_TASKS_GPUS, 0.0));
    --- End diff --
    
    @tillrohrmann I took possible changes in the future into consideration: 
what if Mesos accepts a float for # GPUs? If both of you @tillrohrmann and 
@EronWright think that taking an integer seems better, I'm going to follow your 
opinion 😃  


---

Reply via email to