Github user zhijiangW commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4552#discussion_r162259781
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientFactory.java
 ---
    @@ -164,11 +165,13 @@ private boolean dispose() {
                private void handInChannel(Channel channel) {
                        synchronized (connectLock) {
                                try {
    -                                   PartitionRequestClientHandler 
requestHandler = channel.pipeline()
    -                                                   
.get(PartitionRequestClientHandler.class);
    +                                   NetworkClientHandler clientHandler = 
channel.pipeline().get(PartitionRequestClientHandler.class);
    +                                   if (clientHandler == null) {
    +                                           clientHandler = 
channel.pipeline().get(CreditBasedPartitionRequestClientHandler.class);
    +                                   }
    --- End diff --
    
    good idea!


---

Reply via email to