Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4552#discussion_r162104968
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
 ---
    @@ -125,11 +126,11 @@ private void enqueueAvailableReader(final 
SequenceNumberingViewReader reader) th
         * @return readers which are enqueued available for transferring data
         */
        @VisibleForTesting
    -   ArrayDeque<SequenceNumberingViewReader> getAvailableReaders() {
    +   ArrayDeque<NetworkSequenceViewReader> getAvailableReaders() {
                return availableReaders;
        }
     
    -   void notifyReaderCreated(final SequenceNumberingViewReader reader) {
    +   public void notifyReaderCreated(final NetworkSequenceViewReader reader) 
{
    --- End diff --
    
    this could stay `package-private`


---

Reply via email to