Github user EronWright commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5172#discussion_r161821092
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskManagerRunner.java ---
    @@ -126,12 +124,6 @@ public static void runYarnTaskManager(String[] args, 
final Class<? extends YarnT
                                
hadoopConfiguration.set(CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHENTICATION,
 "kerberos");
    --- End diff --
    
    The block of code labeled 'integration test' seems dangerous.  It appears 
to override the Hadoop configuration whenever there's a keytab.    Since we're 
touching this code, it seems like the right time to remove or to defend this 
'test' code.


---

Reply via email to