[ 
https://issues.apache.org/jira/browse/FLINK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323675#comment-16323675
 ] 

ASF GitHub Bot commented on FLINK-8162:
---------------------------------------

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/5182
  
    Hi @casidiablo, just before merging, I made some refactoring of your PR to 
move the metrics reporting business out of the `ShardConsumer`: 
https://github.com/apache/flink/commit/14b01be8ec1c00b867aea8dc758c23fe247e05f4.
    
    Let me know if you have any objections with that, if not I'll proceed to 
merge soon.


> Kinesis Connector to report millisBehindLatest metric
> -----------------------------------------------------
>
>                 Key: FLINK-8162
>                 URL: https://issues.apache.org/jira/browse/FLINK-8162
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kinesis Connector
>            Reporter: Cristian
>            Priority: Minor
>              Labels: kinesis
>             Fix For: 1.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When reading from Kinesis streams, one of the most valuable metrics is 
> "MillisBehindLatest" (see 
> https://github.com/aws/aws-sdk-java/blob/25f0821f69bf94ec456f602f2b83ea2b0ca15643/aws-java-sdk-kinesis/src/main/java/com/amazonaws/services/kinesis/model/GetRecordsResult.java#L187-L201).
> Flink should use its metrics mechanism to report this value as a gauge, 
> tagging it with the shard id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to