[
https://issues.apache.org/jira/browse/FLINK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316277#comment-16316277
]
ASF GitHub Bot commented on FLINK-8162:
---------------------------------------
Github user casidiablo commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r160139807
--- Diff:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/groups/UnregisteredMetricsGroup.java
---
@@ -107,7 +107,7 @@ public MetricGroup addGroup(String key, String value) {
@Override
public Map<String, String> getAllVariables() {
- return Collections.emptyMap();
+ return new HashMap<>();
--- End diff --
I think it was before (tests were failing because I was using
`...getAllVariables().put("shard_id")...`). I will revert and test.
> Kinesis Connector to report millisBehindLatest metric
> -----------------------------------------------------
>
> Key: FLINK-8162
> URL: https://issues.apache.org/jira/browse/FLINK-8162
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector
> Reporter: Cristian
> Priority: Minor
> Labels: kinesis
> Fix For: 1.5.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When reading from Kinesis streams, one of the most valuable metrics is
> "MillisBehindLatest" (see
> https://github.com/aws/aws-sdk-java/blob/25f0821f69bf94ec456f602f2b83ea2b0ca15643/aws-java-sdk-kinesis/src/main/java/com/amazonaws/services/kinesis/model/GetRecordsResult.java#L187-L201).
> Flink should use its metrics mechanism to report this value as a gauge,
> tagging it with the shard id.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
