[
https://issues.apache.org/jira/browse/FLINK-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290293#comment-16290293
]
ASF GitHub Bot commented on FLINK-7928:
---------------------------------------
Github user shuai-xu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4991#discussion_r156848154
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
---
@@ -52,6 +63,15 @@
/** How many native memory in mb are needed */
private final int nativeMemoryInMB;
+ /** A extensible field for user specified resources from {@link
ResourceSpec}. */
+ private final Map<String, Double> extendedResources = new TreeMap<>();
--- End diff --
HashMap is not ordered, so when comparing two ResourceProfile, the result
may differ if the extended resource are added in different order. Using TreeMap
can promise the comparision of two ResourceProfile is always same if the extend
resources is same.
> Extend the filed in ResourceProfile for precisely calculating the resource of
> a task manager
> --------------------------------------------------------------------------------------------
>
> Key: FLINK-7928
> URL: https://issues.apache.org/jira/browse/FLINK-7928
> Project: Flink
> Issue Type: Improvement
> Components: JobManager, ResourceManager
> Reporter: shuai.xu
> Assignee: shuai.xu
> Labels: flip-6
>
> ResourceProfile records all the resource requirements for a slot。It is
> generated by JobMaster and then passed to ResourceManager with the slot
> request.
> A task in the slot needs three parts of resource:
> 1. The resource for the operators, this is specified by the ResourceSpec user
> defined
> 2. The resource for the operators to communicating with their upstreams. For
> example, the resource for buffer pools and so on.
> 3. The resource for the operators to communicating with their downstreams.
> Same as above.
> So ResourceProfile should contain three parts of resource, the first part
> from ResouceSpec, and the other two part be generated by Job Master.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
