[ 
https://issues.apache.org/jira/browse/FLINK-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289527#comment-16289527
 ] 

ASF GitHub Bot commented on FLINK-7928:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4991#discussion_r156717761
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
 ---
    @@ -61,16 +80,26 @@
         * @param heapMemoryInMB The size of the heap memory, in megabytes.
         * @param directMemoryInMB The size of the direct memory, in megabytes.
         * @param nativeMemoryInMB The size of the native memory, in megabytes.
    +    * @param memoryForInputInMB The size of the memory for input, in 
megabytes.
    +    * @param memoryForOutputInMB The size of the memory for output, in 
megabytes.
         */
        public ResourceProfile(
                        double cpuCores,
                        int heapMemoryInMB,
                        int directMemoryInMB,
    -                   int nativeMemoryInMB) {
    +                   int nativeMemoryInMB,
    +                   int memoryForInputInMB,
    +                   int memoryForOutputInMB,
    --- End diff --
    
    Alright. Can we add this with a separate PR? I would like to not mix 
different things with each other.


> Extend the filed in ResourceProfile for precisely calculating the resource of 
> a task manager
> --------------------------------------------------------------------------------------------
>
>                 Key: FLINK-7928
>                 URL: https://issues.apache.org/jira/browse/FLINK-7928
>             Project: Flink
>          Issue Type: Improvement
>          Components: JobManager, ResourceManager
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>              Labels: flip-6
>
> ResourceProfile records all the resource requirements for a slot。It is 
> generated by JobMaster and then passed to ResourceManager with the slot 
> request. 
> A task in the slot needs three parts of resource: 
> 1. The resource for the operators, this is specified by the ResourceSpec user 
> defined 
> 2. The resource for the operators to communicating with their upstreams. For 
> example, the resource for buffer pools and so on.
> 3. The resource for the operators to communicating with their downstreams. 
> Same as above.
> So ResourceProfile should contain three parts of resource, the first part 
> from ResouceSpec, and the other two part be generated by Job Master.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to