[ https://issues.apache.org/jira/browse/FLINK-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286736#comment-16286736 ]
ASF GitHub Bot commented on FLINK-8217: --------------------------------------- Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5138#discussion_r156231822 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java --- @@ -24,9 +24,13 @@ import static org.apache.flink.util.Preconditions.checkNotNull; /** - * A legacy serializable representation of a AWS Kinesis Stream shard. It is basically a wrapper class around the information - * provided along with {@link com.amazonaws.services.kinesis.model.Shard}. + * A legacy serializable representation of a AWS Kinesis Stream shard. + * It is basically a wrapper class around the information provided along + * with {@link com.amazonaws.services.kinesis.model.Shard}. + * + * @deprecated Will be remove in a future version in favor of {@link StreamShardHandle}. */ +@Deprecated public class KinesisStreamShard implements Serializable { --- End diff -- Although this is deprecated, we should probably also annotate this as `@Internal` > Properly annotate APIs of flink-connector-kinesis > ------------------------------------------------- > > Key: FLINK-8217 > URL: https://issues.apache.org/jira/browse/FLINK-8217 > Project: Flink > Issue Type: Sub-task > Components: Kinesis Connector > Affects Versions: 1.5.0 > Reporter: Bowen Li > Assignee: Bowen Li > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)