[ https://issues.apache.org/jira/browse/FLINK-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286731#comment-16286731 ]
ASF GitHub Bot commented on FLINK-8217: --------------------------------------- Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5138 @bowenli86 @greghogan To my understanding, the proposed changes for FLINK-8192 simply suggests adding proper annotations to the APIs in the Flink connectors. This does not count as a public API change, no? For example, classes such as `KinesisStreamShard` or `SequenceNumber` should be properly annotated as `@Internal`. I understand that by doing so we're narrowing down the "scope" of the public API, but I don't think there's was previously any way that those classes could have been used with the connector in any meaningful way anyways. > Properly annotate APIs of flink-connector-kinesis > ------------------------------------------------- > > Key: FLINK-8217 > URL: https://issues.apache.org/jira/browse/FLINK-8217 > Project: Flink > Issue Type: Sub-task > Components: Kinesis Connector > Affects Versions: 1.5.0 > Reporter: Bowen Li > Assignee: Bowen Li > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)