[ https://issues.apache.org/jira/browse/FLINK-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278578#comment-16278578 ]
ASF GitHub Bot commented on FLINK-8174: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5114#discussion_r154874795 --- Diff: flink-mesos/src/test/java/org/apache/flink/mesos/util/MesosResourceAllocationTest.java --- @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.mesos.util; + +import org.apache.mesos.Protos; +import org.junit.Assert; +import org.junit.Test; + +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.Set; + +import static org.apache.flink.mesos.Utils.range; +import static org.apache.flink.mesos.Utils.ranges; +import static org.apache.flink.mesos.Utils.scalar; +import static org.apache.flink.mesos.util.MesosResourceAllocation.UNRESERVED_ROLE; + +/** + * Tests {@link MesosResourceAllocation}. + */ +public class MesosResourceAllocationTest { --- End diff -- extends `TestLogger` > Mesos RM unable to accept offers for unreserved resources > --------------------------------------------------------- > > Key: FLINK-8174 > URL: https://issues.apache.org/jira/browse/FLINK-8174 > Project: Flink > Issue Type: Bug > Components: Mesos > Affects Versions: 1.4.0, 1.3.3 > Reporter: Eron Wright > Assignee: Eron Wright > Priority: Blocker > Fix For: 1.4.0 > > > Flink has suffered a regression due to FLINK-7294. Any attempt to accept a > resource offer that is based on unreserved resources will fail, because Flink > (as of FLINK-7294) erroneously insists that the resource come from a prior > reservation. > Looking at the original issue, the problem may have been misdiagnosed. > Ideally Flink should work with both reserved and unreserved resources, but > the latter is a more common situation that is now broken. -- This message was sent by Atlassian JIRA (v6.4.14#64029)