[ https://issues.apache.org/jira/browse/FLINK-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278576#comment-16278576 ]
ASF GitHub Bot commented on FLINK-8174: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5114#discussion_r154873853 --- Diff: flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/LaunchCoordinator.scala --- @@ -148,14 +149,17 @@ class LaunchCoordinator( case Event(offers: ResourceOffers, data: GatherData) => val leases = offers.offers().asScala.map( - new VMLeaseObject(_).asInstanceOf[VirtualMachineLease]) + new Offer(_).asInstanceOf[VirtualMachineLease]) --- End diff -- I think we can remove the `asInstanceOf`. > Mesos RM unable to accept offers for unreserved resources > --------------------------------------------------------- > > Key: FLINK-8174 > URL: https://issues.apache.org/jira/browse/FLINK-8174 > Project: Flink > Issue Type: Bug > Components: Mesos > Affects Versions: 1.4.0, 1.3.3 > Reporter: Eron Wright > Assignee: Eron Wright > Priority: Blocker > Fix For: 1.4.0 > > > Flink has suffered a regression due to FLINK-7294. Any attempt to accept a > resource offer that is based on unreserved resources will fail, because Flink > (as of FLINK-7294) erroneously insists that the resource come from a prior > reservation. > Looking at the original issue, the problem may have been misdiagnosed. > Ideally Flink should work with both reserved and unreserved resources, but > the latter is a more common situation that is now broken. -- This message was sent by Atlassian JIRA (v6.4.14#64029)