Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4837#discussion_r145073241
  
    --- Diff: flink-libraries/flink-table/pom.xml ---
    @@ -252,6 +261,29 @@ under the License.
                                                                        
<pattern>org.eigenbase</pattern>
                                                                        
<shadedPattern>org.apache.flink.shaded.calcite.org.eigenbase</shadedPattern>
                                                                </relocation>
    +                                                           <relocation>
    +                                                                   
<pattern>org.pentaho</pattern>
    +                                                                   
<shadedPattern>org.apache.flink.shaded.calcite.org.pentaho</shadedPattern>
    +                                                           </relocation>
    +
    +                                                           <!-- 
flink-table dependencies -->
    +                                                           <relocation>
    +                                                                   
<pattern>org.apache.commons</pattern>
    +                                                                   
<shadedPattern>org.apache.flink.shaded.org.apache.commons</shadedPattern>
    +                                                           </relocation>
    +                                                           <relocation>
    +                                                                   
<pattern>org.reflections</pattern>
    +                                                                   
<shadedPattern>org.apache.flink.shaded.org.reflections</shadedPattern>
    +                                                           </relocation>
    +                                                           <relocation>
    +                                                                   
<pattern>org.joda.time</pattern>
    +                                                                   
<shadedPattern>org.apache.flink.shaded.org.joda.time</shadedPattern>
    +                                                           </relocation>
    +                                                           <!-- not 
relocated for now -->
    --- End diff --
    
    no, but that's exactly what you should write as a comment into the pom ;)


---

Reply via email to