Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4837#discussion_r144848665
  
    --- Diff: flink-libraries/flink-table/pom.xml ---
    @@ -252,6 +261,29 @@ under the License.
                                                                        
<pattern>org.eigenbase</pattern>
                                                                        
<shadedPattern>org.apache.flink.shaded.calcite.org.eigenbase</shadedPattern>
                                                                </relocation>
    +                                                           <relocation>
    +                                                                   
<pattern>org.pentaho</pattern>
    +                                                                   
<shadedPattern>org.apache.flink.shaded.calcite.org.pentaho</shadedPattern>
    +                                                           </relocation>
    +
    +                                                           <!-- 
flink-table dependencies -->
    +                                                           <relocation>
    +                                                                   
<pattern>org.apache.commons</pattern>
    +                                                                   
<shadedPattern>org.apache.flink.shaded.org.apache.commons</shadedPattern>
    --- End diff --
    
    For flink dependencies, please change the shading pattern to 
`org.apache.flink.table.shaded` to a) make them more unique and b) distinguish 
them from flink-shaded dependencies.


---

Reply via email to