[GitHub] flink pull request #4830: [FLINK-7730] [table] Restrict the predicates of ta...

[fhueske]

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4830#discussion_r144809718
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CorrelateITCase.scala
 ---
    @@ -82,6 +86,28 @@ class CorrelateITCase extends 
StreamingMultipleProgramsTestBase {
         assertEquals(expected.sorted, StreamITCase.testResults.sorted)
       }
     
    +  /**
    +    * Due to the improper translation of TableFunction left outer join 
(see CALCITE-2004), this
    +    * test can not be normally passed.
    +    */
    +  @Test(expected = classOf[TableException])
    +  def testLeftOuterJoinWithPredicates(): Unit = {
    +    val t = testData(env).toTable(tEnv).as('a, 'b, 'c)
    +    val func0 = new TableFunc0
    +
    +    val result = t
    +      .leftOuterJoin(func0('c) as('d, 'e))
    +      .where('e < 40)
    --- End diff --
    
    This case is OK.


---