[
https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201350#comment-16201350
]
ASF GitHub Bot commented on FLINK-7416:
---------------------------------------
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4533
@pnowojski , thanks for your reviews!
I should explain the context beforehand.
We present the separate `CreditBasedClientHandler` in order not to affect
the current logic in master branch when partial PRs merged. Actually it would
replace the current `PartitionRequestClientHandler` after all this feature
codes merged.
Different from previous
[FLINK-7406](https://github.com/apache/flink/pull/4509) which is related with
ingoing pipeline logic, and this PR is for outgoing pipeline logic.
> Implement Netty receiver outgoing pipeline for credit-based
> -----------------------------------------------------------
>
> Key: FLINK-7416
> URL: https://issues.apache.org/jira/browse/FLINK-7416
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.4.0
>
>
> This is a part of work for credit-based network flow control.
> The related works are :
> * We define a new message called {{AddCredit}} to notify the incremental
> credit during data shuffle.
> * Whenever an {{InputChannel}}’s unannounced credit goes up from zero, the
> channel is enqueued in the pipeline.
> * Whenever the channel becomes writable, it takes the next {{InputChannel}}
> and sends its unannounced credit. The credit is reset to zero after each sent.
> * That way, messages are sent as often as the network has capacity and
> contain as much credit as available for the channel at that point in time.
> Otherwise, it would only add latency to the announcements and not increase
> throughput.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
