Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4734#discussion_r141580505
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/CurrentJobIdsHandler.java
---
@@ -68,36 +84,9 @@ public CurrentJobIdsHandler(Executor executor, Time
timeout) {
StringWriter writer = new
StringWriter();
JsonGenerator gen =
JsonFactory.JACKSON_FACTORY.createGenerator(writer);
-
- gen.writeStartObject();
-
-
gen.writeArrayFieldStart("jobs-running");
- for (JobID jid :
overview.getJobsRunningOrPending()) {
-
gen.writeString(jid.toString());
- }
- gen.writeEndArray();
-
-
gen.writeArrayFieldStart("jobs-finished");
- for (JobID jid :
overview.getJobsFinished()) {
-
gen.writeString(jid.toString());
- }
- gen.writeEndArray();
-
-
gen.writeArrayFieldStart("jobs-cancelled");
- for (JobID jid :
overview.getJobsCancelled()) {
-
gen.writeString(jid.toString());
- }
- gen.writeEndArray();
-
-
gen.writeArrayFieldStart("jobs-failed");
- for (JobID jid :
overview.getJobsFailed()) {
-
gen.writeString(jid.toString());
- }
- gen.writeEndArray();
-
- gen.writeEndObject();
-
+ new
JobsWithIDsOverview.JobsWithIDsOverviewSerializer().serialize(overview, gen,
null);
--- End diff --
Will change.---
