Github user EronWright commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4628#discussion_r140022455
  
    --- Diff: 
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
 ---
    @@ -155,7 +155,7 @@ public int getPorts() {
     
                @Override
                public List<? extends VMTaskFitnessCalculator> 
getSoftConstraints() {
    -                   return null;
    +                   return params.softConstraints();
    --- End diff --
    
    Let's pass the soft constraints to the launchable mesos worker in its 
constructor, rather than fetching them from the params.    The params aren't a 
good vehicle for this information.


---

Reply via email to