Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/4628#discussion_r140021958 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java --- @@ -366,6 +425,34 @@ public String call(String s) { } /** + * Internal class that stores the parsed information about soft constraint + * It encapsulates fields: + * 1. Host attribute name + * 2. Expected number of unique values for given host attribute + * 3. A callback coTaskGetter used while evaluating balancing constraint + */ + static class BalancedHostAttrConstraintParams { --- End diff -- Please let us make this configuration class immutable. Mark the `hostAttr` and `numOfExpectedUniqueValues` fields as final. Move `coTasksGetter` elsewhere.
---