[ 
https://issues.apache.org/jira/browse/FLINK-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172909#comment-16172909
 ] 

ASF GitHub Bot commented on FLINK-7534:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4603#discussion_r139908232
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/ClusterOverviewHeaders.java
 ---
    @@ -0,0 +1,60 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.messages;
    +
    +import 
org.apache.flink.runtime.messages.webmonitor.StatusOverviewWithVersion;
    +import org.apache.flink.runtime.rest.HttpMethodWrapper;
    +import org.apache.flink.runtime.rest.handler.legacy.ClusterOverviewHandler;
    +
    +import 
org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus;
    +
    +/**
    + * Message headers for the {@link ClusterOverviewHandler}.
    + */
    +public class ClusterOverviewHeaders implements 
MessageHeaders<EmptyRequestBody, StatusOverviewWithVersion, 
EmptyMessageParameters> {
    +   @Override
    +   public Class<EmptyRequestBody> getRequestClass() {
    +           return EmptyRequestBody.class;
    +   }
    +
    +   @Override
    +   public HttpMethodWrapper getHttpMethod() {
    +           return HttpMethodWrapper.GET;
    +   }
    +
    +   @Override
    +   public String getTargetRestEndpointURL() {
    +           return "/overview";
    --- End diff --
    
    Will move `CLUSTER_OVERVIEW_REST_PATH` to `ClusterOverviewHeaders` and 
reference it from `ClusterOverviewHandler`.


> Create LegacyRestHandlerAdapter for the old REST handlers
> ---------------------------------------------------------
>
>                 Key: FLINK-7534
>                 URL: https://issues.apache.org/jira/browse/FLINK-7534
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST, Webfrontend
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>
> Create a {{LegacyRestHandlerAdapter}} to integrate the old REST handler with 
> the new {{RestServerEndpoint}} and the {{AbstractRestHandler}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to